x86 legalize: cardinality preservation is in fact not a requirement#5494
Open
qaco wants to merge 1 commit intoxdslproject:mainfrom
Open
x86 legalize: cardinality preservation is in fact not a requirement#5494qaco wants to merge 1 commit intoxdslproject:mainfrom
qaco wants to merge 1 commit intoxdslproject:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5494 +/- ##
==========================================
- Coverage 85.96% 85.95% -0.01%
==========================================
Files 388 388
Lines 55262 55260 -2
Branches 6354 6354
==========================================
- Hits 47505 47501 -4
- Misses 6247 6248 +1
- Partials 1510 1511 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
approved these changes
Dec 7, 2025
Member
|
It would be nice to have a test with a minimal version of the code that wasn't correctly handled before and would be now, but more of a nit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.