dialects: (riscv) add rv32, rv64 dialects#5589
dialects: (riscv) add rv32, rv64 dialects#5589osmanyasar05 wants to merge 35 commits intoxdslproject:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5589 +/- ##
==========================================
- Coverage 86.25% 86.21% -0.05%
==========================================
Files 403 405 +2
Lines 56660 56810 +150
Branches 6512 6531 +19
==========================================
+ Hits 48871 48976 +105
- Misses 6268 6303 +35
- Partials 1521 1531 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@superlopuh I want to ask whether we are keeping some parts of the |
|
I'm not 100% sure, for now I would only touch the shift ops and think about the other ops later |
|
Merged the changes. Should I move forward with moving more operations to the corresponding dialect files? @superlopuh |
xdslproject#5615) This PR just makes sure that fastmath flags from the original op are preserved when approximating.
It's not pretty and not consistent with riscv.
…ect#5485) Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com> Co-authored-by: Mathieu Fehr <mathieu.fehr@gmail.com>
|
Merged changes from a259e76. Will work on getting shift instructions merged now. |
|
Added comments to the operations and changed some wrong links to docs in comments. |
luisacicolini
left a comment
There was a problem hiding this comment.
left a few style nits, otherwise lgtm - thank you!
addressed these comments! now the PR only has changes related to shift instructions @superlopuh |
This PR adds
riscv32andriscv64dialects.