Skip to content

traits: (SymbolTable) Add transparent flag to have non-shadowing symbol tables#5625

Draft
AntonLydike wants to merge 1 commit intomainfrom
anton/allow-transparent-symbol-tables
Draft

traits: (SymbolTable) Add transparent flag to have non-shadowing symbol tables#5625
AntonLydike wants to merge 1 commit intomainfrom
anton/allow-transparent-symbol-tables

Conversation

@AntonLydike
Copy link
Collaborator

This adds a transparent flag (default to False) to the SymbolTabe trait and modifies the lookup behaviour to keep searching parent ops in case the table does not contain the symbol.

The idea is to allow nesting symbol table ops without "cutting off" access to global functions.

@AntonLydike
Copy link
Collaborator Author

Tests incoming this afternoon

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.17%. Comparing base (69a5f05) to head (a2c1ae6).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/traits.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5625      +/-   ##
==========================================
+ Coverage   86.16%   86.17%   +0.01%     
==========================================
  Files         395      399       +4     
  Lines       56475    56551      +76     
  Branches     6507     6509       +2     
==========================================
+ Hits        48661    48734      +73     
- Misses       6280     6282       +2     
- Partials     1534     1535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@superlopuh
Copy link
Member

Is this conformant with MLIR?

@AntonLydike
Copy link
Collaborator Author

Is this conformant with MLIR?

As far as I know MLIR does not have anything like this. I didn't look very deeply into their definitions though, only looked through the docs.

@AntonLydike AntonLydike marked this pull request as draft February 6, 2026 13:50
@superlopuh
Copy link
Member

Hi @AntonLydike, what are your plans here?

@AntonLydike
Copy link
Collaborator Author

Checking with Josse, I think we ended up resolving this a different way, will report back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants