traits: (SymbolTable) Add transparent flag to have non-shadowing symbol tables#5625
Draft
AntonLydike wants to merge 1 commit intomainfrom
Draft
traits: (SymbolTable) Add transparent flag to have non-shadowing symbol tables#5625AntonLydike wants to merge 1 commit intomainfrom
AntonLydike wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Tests incoming this afternoon |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5625 +/- ##
==========================================
+ Coverage 86.16% 86.17% +0.01%
==========================================
Files 395 399 +4
Lines 56475 56551 +76
Branches 6507 6509 +2
==========================================
+ Hits 48661 48734 +73
- Misses 6280 6282 +2
- Partials 1534 1535 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Is this conformant with MLIR? |
Collaborator
Author
As far as I know MLIR does not have anything like this. I didn't look very deeply into their definitions though, only looked through the docs. |
Member
|
Hi @AntonLydike, what are your plans here? |
Collaborator
Author
|
Checking with Josse, I think we ended up resolving this a different way, will report back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
transparentflag (default toFalse) to theSymbolTabetrait and modifies the lookup behaviour to keep searching parent ops in case the table does not contain the symbol.The idea is to allow nesting symbol table ops without "cutting off" access to global functions.