testing: add tests for newly added parse_spec function#5696
Merged
superlopuh merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5696 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 406 406
Lines 57704 57707 +3
Branches 6704 6704
=======================================
+ Hits 49825 49828 +3
Misses 6322 6322
Partials 1557 1557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexarice
reviewed
Mar 6, 2026
Collaborator
alexarice
left a comment
alexarice
left a comment
There was a problem hiding this comment.
I'm not sure about changing this parse_spec interface
|
|
||
|
|
||
| def parse_spec(lexer: PipelineLexer) -> PipelinePassSpec: | ||
| def parse_spec(spec: str) -> PipelinePassSpec: |
Collaborator
There was a problem hiding this comment.
If this is used only for the one test then I'd just inline it to that test.
Member
Author
There was a problem hiding this comment.
Sorry I'll open the stack of changes that are incoming that use this function specifically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My push adding tests to #5695 didn't work for some reason, this is more of a quick fix PR to add the tests before moving onto the next change.