Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5706 +/- ##
==========================================
+ Coverage 86.34% 86.35% +0.01%
==========================================
Files 406 406
Lines 57753 57800 +47
Branches 6709 6711 +2
==========================================
+ Hits 49869 49916 +47
Misses 6325 6325
Partials 1559 1559 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Needs some more code quality improvements. Created PR too early. |
Contributor
Author
|
Done |
superlopuh
reviewed
Mar 7, 2026
|
|
||
| @property | ||
| def int_value(self) -> int: | ||
| return list(type(self)).index(self) |
Member
There was a problem hiding this comment.
why remove the old mechanism with a dict?
Member
There was a problem hiding this comment.
I'd rather duplicate the code TBH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.