Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5710 +/- ##
=======================================
Coverage 86.34% 86.35%
=======================================
Files 406 406
Lines 57753 57796 +43
Branches 6709 6720 +11
=======================================
+ Hits 49869 49909 +40
- Misses 6325 6326 +1
- Partials 1559 1561 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Mar 7, 2026
Comment on lines
+586
to
589
| // CHECK: define i32 @"cond_br_op"(i1 %".1", i32 %".2", i32 %".3") | ||
| // CHECK: br i1 %".1", label %{{.*}}, label %{{.*}} | ||
| // CHECK: ret i32 | ||
|
|
Member
There was a problem hiding this comment.
why not check for the whole function?
superlopuh
reviewed
Mar 7, 2026
Comment on lines
+50
to
+52
| // CHECK: llvm.cond_br %cond_br_cond, ^bb1(%cond_br_arg : i32), ^bb2(%cond_br_arg : i32) | ||
| // CHECK: ^bb1(%cond_br_then : i32): | ||
| // CHECK: ^bb2(%cond_br_else : i32): |
Member
There was a problem hiding this comment.
why not check whole thing here?
superlopuh
reviewed
Mar 7, 2026
| if block.args: | ||
| builder = ir.IRBuilder(block_map[block]) | ||
| for arg in block.args: | ||
| phi = builder.phi(convert_type(arg.type)) |
Member
There was a problem hiding this comment.
this seems weird, are these ops modified later? worth a comment IMO where in the code the arguments will be provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.