Open
Conversation
|
xente
approved these changes
Aug 21, 2025
Owner
|
@Jerakin Can you resolve the conflict please? |
Jerakin
force-pushed
the
feat/logformatter-abc
branch
from
32ed257 to
8b9fd18
Compare
Jerakin
force-pushed
the
feat/logformatter-abc
branch
from
8b9fd18 to
2352495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better illustrate how the formatters should be used I suggest adding a ABC. This can then also be used in type hints.
Note: I would normally have done this with a protocol, but as the project aim to support 2.7 using an ABC is simpler.