Skip to content

Renderers refactor #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 697 commits into
base: master
Choose a base branch
from
Draft

Renderers refactor #1850

wants to merge 697 commits into from

Conversation

MichalDybizbanskiCreoox
Copy link
Collaborator

No description provided.

@MichalDybizbanskiCreoox
Migrate PickDepthProgram to lazyShaderUniform
c4af493
@MichalDybizbanskiCreoox
Migrate SilhouetteProgram to lazyShaderUniform
b8f4365
@MichalDybizbanskiCreoox
Migrate SnapProgram to lazyShaderUniform
855dfb2
@MichalDybizbanskiCreoox
Move model{Normal}Matrix to lazyShaderAttribute and uvDecodeMatrix to…
a7798fa 
… lazyShaderUniform
@MichalDybizbanskiCreoox
Move VBO attributes to lazyShaderAttribute
27347d3
@MichalDybizbanskiCreoox
Use LayerRenderer::lazyShaderVariable in VBOLayer
5b1f58a
@MichalDybizbanskiCreoox
Move mipmap calculation to PBRProgram
7920e35
@MichalDybizbanskiCreoox
Replace createLightSetup::getDirectionalLights with ::directionalLigh…
76c1ff2 
…ts and migrate to lightsStateUniform
@MichalDybizbanskiCreoox
Migrate layer createLightSetup to setupCubeTexture
e649a75
@MichalDybizbanskiCreoox
Add assignTextureUnitsAutomatically argument to makeInputSetters
c67a0d7
@MichalDybizbanskiCreoox
FIX missing offset influence on billboarded meshes in EmphasisFillSha…
d66dae3 
…derSource (skipped by ee5de4b)
@MichalDybizbanskiCreoox
FIX missing frameCtx.bindTexture++ increment
c2c631c
@MichalDybizbanskiCreoox
FIX missing "#version 300 es" declarations in ShadowShaderSource
0839fa3
@MichalDybizbanskiCreoox
FIX incorrect sectionPlanes.length call in ShadowShaderSource
cff58dc
@MichalDybizbanskiCreoox
FIX worldNormal fourth component to 0.0
29fca2c
@MichalDybizbanskiCreoox
FIX ambientTexel assignment
07b09ae
@MichalDybizbanskiCreoox
FIX normalMap uniform definitions test
1f69ad7
@MichalDybizbanskiCreoox
FIX Mesh::_pickTriangleRenderer.webglContextRestored call
657be20
@MichalDybizbanskiCreoox
FIX {Draw,Occlusion,PickMesh,PickTriangle,Shadow}Renderer _uSectionPl…
f7261b3 
…anes to depend on getNumAllocatedSectionPlanes
@MichalDybizbanskiCreoox
FIX section planes state setting in ShadowRenderer::drawMesh
286b5e2
@MichalDybizbanskiCreoox
FIX incorrect geometryState.positions reference to geometryState.posi…
99552b4 
…tionsBuf
@MichalDybizbanskiCreoox
FIX Add lightsState.getHash() to EmphasisFillRenderer hash
b03e695
@MichalDybizbanskiCreoox
Remove PickMeshShaderSource billboarding, as it's broken anyway
a7fd7a0 
Can be tested with scenegraph/billboarding_Mesh_spherical.html example
@MichalDybizbanskiCreoox
Remove unused pointSize refereneces from EmphasisFillShaderSource and…
edeaf74 
… ShadowRenderer
@MichalDybizbanskiCreoox
Remove unused LambertMaterial _uMaterialAmbient assignment (materialA…
0f0f242 
…mbient not used by buildVertexLambert)
@MichalDybizbanskiCreoox
Remove unused LambertMaterial _uAlphaModeCutoff assignment (materialA…
32fac38 
…lphaModeCutoff not used by buildVertexLambert)
@MichalDybizbanskiCreoox
Remove unused gammaToLinear DrawShaderSource definition
148a445
@MichalDybizbanskiCreoox
Remove unused _uUVDecodeMatrix setup from EmphasisFillRenderer
4286dc6
@MichalDybizbanskiCreoox
Reorganize LayerRenderer and Mesh renderer to have similar fragment a…
da827a3 
…ssembly
@MichalDybizbanskiCreoox
Move common fragment assembly inside buildProgram
a6f5915
@MichalDybizbanskiCreoox
Simplify LayerRenderer
7d34eb4
@MichalDybizbanskiCreoox
Inline LayerRenderer's buildProgram parameters
870ee3f
@MichalDybizbanskiCreoox
Migrate from renderingAttributes.drawCall to layer.drawCalls
151d6f7
@MichalDybizbanskiCreoox
Move lazyShaderVariable definition to VBOLayer.js from LayerRenderer.js
872f51d
@MichalDybizbanskiCreoox
Inline LayerRenderer inside getRenderers
d9e0ec4
@MichalDybizbanskiCreoox
Move texture matrix handling from general setupTexture to DrawShaderS…
89eef13 
…ource
@MichalDybizbanskiCreoox
Separate texeFetch from setupTexture
baf1f91
@MichalDybizbanskiCreoox
Change DTX perPrimIndices and perPrimIdPorIds to be set explicitly by…
1cfb37b 
… drawCalls
@MichalDybizbanskiCreoox
Replace redundant renderingAttributes isVBO flag by dontCullOnAlphaZero
ab37b36
@MichalDybizbanskiCreoox
Replace getClippable by a clippable attribute
23fc65b
@MichalDybizbanskiCreoox
Replace getFlag with a flags attribute array
88b3fcb
@MichalDybizbanskiCreoox
Condition VBO modelNormalMatrix glsl multiplication on modelNormalMat…
c30948f 
…rixColBufs presence
@MichalDybizbanskiCreoox
Move octDecode definition inside programVariables.commonLibrary
28bc6ab
@MichalDybizbanskiCreoox
Clean up makeVBORenderingAttributes
c14ba13
@MichalDybizbanskiCreoox
Replace renderingAttributes.signature by cacheKey
eb82572
@MichalDybizbanskiCreoox
Move vbo/dtx renderers definitions around, to be near drawCalls
7fa672b
@MichalDybizbanskiCreoox
CHANGE Expose dtx worldNormal
f3cedf3
@MichalDybizbanskiCreoox
Enable pickNormalsRenderer and shadowRenderer for dtx
3762838
@MichalDybizbanskiCreoox
Replace getRenderers' isVBO argument with more explicit saoEnabled, p…
0b5b713 
…brSupported, colorTextureSupported, surfaceHasNormals
@MichalDybizbanskiCreoox
Migrate to explicit dtx and vbo specific inputs setting
d6b64da
@MichalDybizbanskiCreoox
Migrate to explicit mesh specific attributes setting
41cfab4
@MichalDybizbanskiCreoox
Migrate to explicit mesh specific uniforms setting
2ac3494
@MichalDybizbanskiCreoox
Inline createSectionPlanesSetup
aa5c23f
@MichalDybizbanskiCreoox
Abstract vbo makeDrawer
09d35e0
@MichalDybizbanskiCreoox
Replace transformClipPos() by vertexClipPosition
7f62c01
@MichalDybizbanskiCreoox
Generate createFragmentDefinition appenders before other fragAppenders
998b102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeolabs xeolabs Awaiting requested review from xeolabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichalDybizbanskiCreoox