-
Notifications
You must be signed in to change notification settings - Fork 11
chore: enable e2e-bm in ci. #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Summary of ChangesHello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the continuous integration (CI) configuration by renaming an existing file and introducing a new YAML configuration for a local 'flame' cluster. These changes are part of an effort to enable end-to-end benchmarks within the CI pipeline, providing a dedicated and detailed setup for the 'flame' environment's network services and package management. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request renames a configuration file and introduces a new client-side configuration for a local Flame cluster (ci/flame-local.yaml). This change is crucial for enabling e2e-bm in CI. However, there are critical mismatches in the endpoint and cache endpoint configurations in the newly added file, which will prevent successful connection to the local cluster services.
| current-cluster: flame | ||
| clusters: | ||
| - name: flame | ||
| endpoint: "http://127.0.0.1:8080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The endpoint port 8080 in this client configuration file (ci/flame-local.yaml) does not match the endpoint port 30080 configured for the local Flame session manager in ci/flame-cluster-local.yaml. This mismatch will prevent the client from connecting to the session manager.
endpoint: "http://127.0.0.1:30080"| - name: flame | ||
| endpoint: "http://127.0.0.1:8080" | ||
| cache: | ||
| endpoint: "grpc://127.0.0.1:9090" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache.endpoint protocol grpc in this client configuration file (ci/flame-local.yaml) does not match the http protocol configured for the local cache endpoint in ci/flame-cluster-local.yaml. This protocol mismatch will prevent the client from connecting to the cache service.
endpoint: "http://127.0.0.1:9090"Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
No description provided.