ENH: Set units and long_name attributes on function results.#217
Draft
DWesl wants to merge 3 commits intoxgcm:masterfrom
Draft
ENH: Set units and long_name attributes on function results.#217DWesl wants to merge 3 commits intoxgcm:masterfrom
DWesl wants to merge 3 commits intoxgcm:masterfrom
Conversation
As determined by units. It can work okay with some tweaking away from poles. It does not work near poles or over a large latitude range.
Currently failing, for reasons I don't understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only very basic testing so far.
I should expand that to check that they are getting set or not as appropriate.
Should help avoid situations like #92.
Initial attempt at #169, for the metadata I use most.