Skip to content

[Snyk] Fix for 3 vulnerabilities #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaobin wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[Snyk] Fix for 3 vulnerabilities #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mi-blog/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
<version>1.2.31</version>
<version>1.2.48</version>
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade to fastjson 1.2.48 is insufficient and leaves the application vulnerable. Fastjson version 1.2.48 has numerous known critical security vulnerabilities (CVEs) including remote code execution flaws. The minimum recommended version is 1.2.83 or higher. Consider upgrading to the latest stable version of fastjson (2.x series) to ensure all known vulnerabilities are addressed.

Suggested change
<version>1.2.48</version>
<version>2.0.52</version>

Copilot uses AI. Check for mistakes.
</dependency>

<dependency>
Comment on lines +103 to 106
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description claims to fix 3 vulnerabilities including two critical Tomcat vulnerabilities (SNYK-JAVA-ORGAPACHETOMCATEMBED-8523186 and SNYK-JAVA-ORGAPACHETOMCATEMBED-8547999), but this PR only upgrades the fastjson dependency. The Tomcat vulnerabilities are brought in through the Spring Boot dependencies (version 1.5.2.RELEASE) and remain unaddressed. This creates a false sense of security as the PR title suggests all 3 vulnerabilities are fixed when in reality only a partial fix for 1 vulnerability is attempted.

Suggested change
<version>1.2.48</version>
</dependency>
<dependency>
<version>1.2.83</version>
</dependency>
<!-- Override embedded Tomcat to secure versions to address SNYK-JAVA-ORGAPACHETOMCATEMBED-8523186 and SNYK-JAVA-ORGAPACHETOMCATEMBED-8547999 -->
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-core</artifactId>
<version>8.5.88</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-el</artifactId>
<version>8.5.88</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-websocket</artifactId>
<version>8.5.88</version>
</dependency>
<dependency>

Copilot uses AI. Check for mistakes.
Expand Down