Skip to content

Refactor AnnotatedVerses Activity / ViewModel to use single view state#238

Merged
xizzhu merged 1 commit intomasterfrom
refactor_annotated_verses
Nov 25, 2022
Merged

Refactor AnnotatedVerses Activity / ViewModel to use single view state#238
xizzhu merged 1 commit intomasterfrom
refactor_annotated_verses

Conversation

@xizzhu
Copy link
Owner

@xizzhu xizzhu commented Nov 25, 2022

Essentially part of #233, which is too big to manage.

@codecov-commenter
Copy link

Codecov Report

Merging #238 (f7ebd72) into master (772ba5b) will increase coverage by 0.95%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   52.83%   53.78%   +0.95%     
==========================================
  Files         125      123       -2     
  Lines        4705     4791      +86     
  Branches      618      630      +12     
==========================================
+ Hits         2486     2577      +91     
+ Misses       2145     2142       -3     
+ Partials       74       72       -2     
Impacted Files Coverage Δ
.../main/kotlin/me/xizzhu/android/joshua/Injection.kt 0.00% <0.00%> (ø)
...ndroid/joshua/annotated/AnnotatedVersesActivity.kt 0.00% <0.00%> (ø)
...oshua/core/provider/CoroutineDispatcherProvider.kt 0.00% <ø> (ø)
...izzhu/android/joshua/core/provider/TimeProvider.kt 0.00% <0.00%> (ø)
...n/me/xizzhu/android/joshua/infra/BaseActivityV2.kt 0.00% <0.00%> (ø)
...ndroid/joshua/strongnumber/StrongNumberActivity.kt 0.00% <0.00%> (ø)
...id/joshua/annotated/bookmarks/BookmarksActivity.kt 81.81% <81.81%> (+15.15%) ⬆️
.../joshua/annotated/highlights/HighlightsActivity.kt 81.81% <81.81%> (+15.15%) ⬆️
...hu/android/joshua/annotated/notes/NotesActivity.kt 75.00% <90.00%> (+25.00%) ⬆️
...droid/joshua/annotated/AnnotatedVersesViewModel.kt 99.27% <100.00%> (+27.22%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xizzhu xizzhu merged commit 800af72 into master Nov 25, 2022
@xizzhu xizzhu deleted the refactor_annotated_verses branch November 25, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants