Skip to content

Refactor ReadingProgress Activity / ViewModel to use single view state#240

Merged
xizzhu merged 2 commits intomasterfrom
refactor_reading_progress
Nov 27, 2022
Merged

Refactor ReadingProgress Activity / ViewModel to use single view state#240
xizzhu merged 2 commits intomasterfrom
refactor_reading_progress

Conversation

@xizzhu
Copy link
Owner

@xizzhu xizzhu commented Nov 27, 2022

Essentially part of #233, which is too big to manage.

The refactoring to use ListAdapter is to eventually eliminate the usage of the custom CommonRecyclerView.

@xizzhu xizzhu force-pushed the refactor_reading_progress branch from 689f7f7 to 9fc9e9b Compare November 27, 2022 05:15
@codecov-commenter
Copy link

Codecov Report

Merging #240 (9fc9e9b) into master (4be63ab) will increase coverage by 1.29%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   53.98%   55.27%   +1.29%     
==========================================
  Files         123      123              
  Lines        4883     4937      +54     
  Branches      649      657       +8     
==========================================
+ Hits         2636     2729      +93     
+ Misses       2176     2138      -38     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
...ndroid/joshua/annotated/AnnotatedVersesActivity.kt 0.00% <0.00%> (ø)
...n/me/xizzhu/android/joshua/infra/BaseActivityV2.kt 0.00% <0.00%> (ø)
...android/joshua/progress/ReadingProgressActivity.kt 0.00% <0.00%> (ø)
.../me/xizzhu/android/joshua/search/SearchActivity.kt 0.00% <0.00%> (ø)
...ndroid/joshua/strongnumber/StrongNumberActivity.kt 0.00% <0.00%> (ø)
.../android/joshua/progress/ReadingProgressAdapter.kt 41.66% <41.66%> (ø)
...ndroid/joshua/progress/ReadingProgressViewModel.kt 100.00% <100.00%> (+8.51%) ⬆️
...zzhu/android/joshua/progress/ReadingProgressBar.kt 37.25% <0.00%> (+37.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xizzhu xizzhu merged commit b5d96cd into master Nov 27, 2022
@xizzhu xizzhu deleted the refactor_reading_progress branch November 27, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants