Refactor ReadingProgress Activity / ViewModel to use single view state#240
Merged
Refactor ReadingProgress Activity / ViewModel to use single view state#240
Conversation
689f7f7 to
9fc9e9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 53.98% 55.27% +1.29%
==========================================
Files 123 123
Lines 4883 4937 +54
Branches 649 657 +8
==========================================
+ Hits 2636 2729 +93
+ Misses 2176 2138 -38
+ Partials 71 70 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially part of #233, which is too big to manage.
The refactoring to use
ListAdapteris to eventually eliminate the usage of the customCommonRecyclerView.