fix duplicate types created by aliases#186
Open
tomas-mraz wants to merge 2 commits intoxlab:masterfrom
Open
Conversation
tomas-mraz
force-pushed
the
fix/duplicate_types
branch
from
cd3bfbd to
e650005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases for types creating duplicity definitions. This patch fixes it.
The first commit stops creating definitions, but it still generates comments with empty "const".
The second one stops creating comments and empty "const" definitions.
This way, it's better to read and understand, but of course, it's ok to squash it.
Tested on Vulkan API headers v1.3.241.