BREAKING CHANGE:Streamline to align better with jwk api. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE! A few of the options go away in favor of leaning on the jws/jwk library and jwskeychain to provide more of that verification. Removed: - RequirePolicies - Require - TrustRootCAs - Verifier - SignWith - SignWithRaw Added: - Signer - NewSigner - SignWithX509Chain - SignWithKey - Decoder - NewDecoder - WithKeyProvider - WithKeySet - WithKeyUsed - WithVerifyAuto This was done to incorporate the flexability available from the jws/jwk libraries but limit some of the things that could be configured that would break this library.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 74.22% 72.97% -1.25%
==========================================
Files 11 11
Lines 803 766 -37
==========================================
- Hits 596 559 -37
- Misses 167 169 +2
+ Partials 40 38 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE!
A few of the options go away in favor of leaning on the jws/jwk library and jwskeychain to provide more of that verification.
Removed:
Added:
This was done to incorporate the flexability available from the jws/jwk libraries but limit some of the things that could be configured that would break this library.