Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Comments in filter_fir_s32.S still reference old architectural register names (x18, x19) after the codebase transitioned to ABI names (s2, s3).

Changes:

  • Update comments at lines 166-167 and 174 to use ABI register names (s2, s3) instead of architectural names (x18, x19)

The code itself is correct—only documentation is stale:

// Before:
// (from the block above):  x19 = 1, x18 = 1<<(a2 - 1)

// After:
// (from the block above):  s3 = 1, s2 = 1<<(a2 - 1)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Clean up lib_xcore_math filter code and reduce stack usage Update stale register name comments in filter_fir_s32.S Jan 30, 2026
@andrewstanfordjason
Copy link
Contributor

this is pointless!

@andrewstanfordjason andrewstanfordjason deleted the copilot/sub-pr-209 branch January 30, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants