Skip to content

(via api-Hypernova): Fix trace hierarchy by using subscribeCtx in SubscribeEnvelopes call#1591

Merged
api-Hypernova merged 11 commits intohypernova/apm-cleanfrom
macroscope/hypernova/apm-clean
Feb 6, 2026
Merged

(via api-Hypernova): Fix trace hierarchy by using subscribeCtx in SubscribeEnvelopes call#1591
api-Hypernova merged 11 commits intohypernova/apm-cleanfrom
macroscope/hypernova/apm-clean

Conversation

@macroscopeapp
Copy link

@macroscopeapp macroscopeapp bot commented Feb 2, 2026

Macroscope: Fix It For Me

  • This PR originated from this comment in Add APM support to XMTPD #1589.
  • Since auto-merge is on, Macroscope will merge this PR after waiting for checks to pass.
  • If you'd rather not wait, you can always merge this yourself but no further action from you is currently needed.
  • You can also @mention Macroscope in this PR to request further changes.

Activity

Currently: Merged by api-Hypernova

Previously
  • Not merged: conflicts
  • Waiting on checks
  • Not merged: conflicts
  • Waiting on checks
  • Not merged: conflicts
  • Waiting on checks
  • Encountered unknown error
  • Action failed: Test
  • Waiting on checks
  • Action failed: Lint
  • Waiting on checks
  • Action failed: Lint
  • Waiting on checks
  • Action failed: Lint
  • Waiting on checks
  • Action failed: Lint
  • Waiting on checks
  • Pushed 3c6e6ef

Use subscribeCtx for client.SubscribeEnvelopes in syncWorker.setupStream and change stable hashing to selectors.HashKey(topic.Identifier()) with tests updated to ±10% tolerance and new node order

Propagate child span context into subscription and reserved envelope storage, switch stable hashing to topic identifier, add SQL to set work_mem, enforce payer_id FKs, and migrate latest envelope tracking to a statement-level trigger.

📍Where to Start

Start with syncWorker.setupStream in service.go and sync_worker.go in sync_worker.go to see the subscribeCtx usage, then review selectors.HashKey in stable.go.


Macroscope summarized 24933b8.

@macroscopeapp macroscopeapp bot requested a review from a team as a code owner February 2, 2026 17:13
@api-Hypernova api-Hypernova merged commit da87da9 into hypernova/apm-clean Feb 6, 2026
3 checks passed
@api-Hypernova api-Hypernova deleted the macroscope/hypernova/apm-clean branch February 6, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant