add go sidecar build by mchenani · Pull Request #1622 · xmtp/xmtpd

mchenani · 2026-02-11T19:36:43Z

No description provided.

npm/gateway/src/process-manager.ts

npm/sync-versions.sh

npm/gateway/src/process-manager.ts

mkysel · 2026-02-11T19:40:38Z

npm/gateway/src/process-manager.ts

+    XMTPD_API_PORT: String(port),
+    XMTPD_API_ENABLE: "true",


does it need the API? Thats a lot of computation for nothing

for now just testing, will clean it up later.

mkysel · 2026-02-11T19:45:17Z

.github/workflows/publish-gateway-npm.yml

+
+on:
+  push:
+    branches: [main, dev]


there is no dev branch

mkysel · 2026-02-11T19:49:13Z

@mchenani this particular implementation of the gateway does not support any extensions or JWT token auth. Does that meet your requirements?

mchenani · 2026-02-11T19:51:18Z

@mchenani this particular implementation of the gateway does not support any extensions or JWT token auth. Does that meet your requirements?

Thanks for the review, tbh I'm not sure if I'm aware of the requirements there, will discuss them with @cameronvoell to make sure I have the full picture how we want to tackle that.

macroscopeapp · 2026-02-12T16:17:12Z

Removed Windows platform support from gateway binary resolution and installation [3a8281c]
Removed auto-restart functionality and changed process lifecycle management in startGateway [3a8281c]
Refactored health check and port availability detection logic [3a8281c]
Implemented buffered log forwarding with partial line handling [3a8281c]
Gated npm publishing and tagging to run only on main branch [3a8281c]
Added command injection protection to version synchronization script [3a8281c]

Changes since #1622 opened

Updated conditional execution logic for npm package publishing steps in GitHub workflow [265ca0d]
Replaced dev npm tag with poc tag and updated automatic tag selection logic in publish-gateway-npm workflow [8da95fa]
Modified versioning strategy to apply -<tag>.<git-hash> suffix to all non-latest tags [8da95fa]
Removed branch-based publication constraints from all publish steps in publish-gateway-npm workflow [8da95fa]
Removed path filters from the publish-gateway-npm.yml workflow trigger configuration [ef95594]
Added public access and provenance configuration to npm publish steps [c03b2cf]
Replaced JS-DevTools/npm-publish action with direct npm publish CLI commands for publishing packages @xmtp/gateway-darwin-arm64, @xmtp/gateway-darwin-x64, @xmtp/gateway-linux-arm64, @xmtp/gateway-linux-x64, and @xmtp/gateway in the GitHub Actions workflow [90fe32d]
Modified npm package publishing authentication and provenance configuration in the publish-gateway-npm.yml workflow [f3127ba]
Added npm version update step to the publish-gateway-npm.yml workflow [f3127ba]

📊 Macroscope summarized 265ca0d. 11 files reviewed, 9 issues evaluated, 4 issues filtered, 1 comment posted. View details

npm/gateway/src/process-manager.ts

macroscopeapp · 2026-02-12T16:20:50Z

npm/gateway/src/process-manager.ts

+function setupLogForwarding(child: ChildProcess): void {
+  let buffer = "";
+  child.stdout?.on("data", (data: Buffer) => {
+    buffer += data.toString();


🟡 Medium

src/process-manager.ts:90 The buffer grows unbounded if stdout never emits newlines. Consider capping buffer size (e.g., 1MB) and discarding/truncating when exceeded, or document why this is acceptable for the expected gateway output format.

🚀 Want me to fix this? Reply ex: "fix it for me".

🤖 Prompt for AI

In file npm/gateway/src/process-manager.ts around line 90: The `buffer` grows unbounded if stdout never emits newlines. Consider capping buffer size (e.g., 1MB) and discarding/truncating when exceeded, or document why this is acceptable for the expected gateway output format.

macroscopeapp · 2026-02-12T16:20:51Z

npm/gateway/src/process-manager.ts

+
+  const timeout = config.healthCheckTimeout ?? 30_000;
+  try {
+    await Promise.race([waitForHealthy(port, timeout), earlyExit]);


🟡 Medium

src/process-manager.ts:42 Consider verifying the gateway actually bound to the port, not just that the port is in use. If another process occupies the port, waitForHealthy succeeds immediately while the gateway fails to bind. One option: hit the gateway's health endpoint instead of just checking port occupancy.

🚀 Want me to fix this? Reply ex: "fix it for me".

🤖 Prompt for AI

In file npm/gateway/src/process-manager.ts around line 42: Consider verifying the gateway actually bound to the port, not just that the port is in use. If another process occupies the port, `waitForHealthy` succeeds immediately while the gateway fails to bind. One option: hit the gateway's health endpoint instead of just checking port occupancy.

macroscopeapp · 2026-02-12T16:20:51Z

npm/gateway/src/process-manager.ts

+    server.once("listening", () => {
+      server.close();
+      resolve(false);


🟡 Medium

src/process-manager.ts:148 Consider waiting for the close event before resolving, since server.close() is asynchronous and the port may not be released yet when findAvailablePort returns.

Suggested change

server.once("listening", () => {

server.close();

resolve(false);

server.once("listening", () => {

server.close(() => resolve(false));

});

🚀 Want me to fix this? Reply ex: "fix it for me".

🤖 Prompt for AI

In file npm/gateway/src/process-manager.ts around lines 148-150: Consider waiting for the `close` event before resolving, since `server.close()` is asynchronous and the port may not be released yet when `findAvailablePort` returns.

macroscopeapp · 2026-02-12T16:30:38Z

npm/build.sh

+  echo "  Building ${goos}/${goarch} -> ${output}"
+  CGO_ENABLED=0 GOOS="${goos}" GOARCH="${goarch}" \


🟠 High

npm/build.sh:15 go build -o doesn't create parent directories. Consider adding mkdir -p "$(dirname "${output}")" before the build command.

Suggested change

echo " Building ${goos}/${goarch} -> ${output}"

CGO_ENABLED=0 GOOS="${goos}" GOARCH="${goarch}" \

echo " Building ${goos}/${goarch} -> ${output}"

mkdir -p "$(dirname "${output}")"

CGO_ENABLED=0 GOOS="${goos}" GOARCH="${goarch}" \

🚀 Want me to fix this? Reply ex: "fix it for me".

🤖 Prompt for AI

In file npm/build.sh around lines 15-16: `go build -o` doesn't create parent directories. Consider adding `mkdir -p "$(dirname "${output}")"` before the build command.

add go sidecar build

61c37d4

mchenani marked this pull request as ready for review February 11, 2026 19:37

mchenani requested a review from a team as a code owner February 11, 2026 19:37

mchenani marked this pull request as draft February 11, 2026 19:37

macroscopeapp bot reviewed Feb 11, 2026

View reviewed changes

mkysel reviewed Feb 11, 2026

View reviewed changes

refactor and add current branch to gh action to test

3a8281c

macroscopeapp bot reviewed Feb 12, 2026

View reviewed changes

add workflow_dispatch to publish gateway npm

265ca0d

macroscopeapp bot reviewed Feb 12, 2026

View reviewed changes

mchenani added 5 commits February 12, 2026 18:27

tirgger workflow from current branch

8da95fa

tirgger workflow from current branch

ef95594

fix npm publish ghaction

c03b2cf

fix npm publish ghaction

90fe32d

fix npm publish ghaction

f3127ba

		echo " Building ${goos}/${goarch} -> ${output}"
		CGO_ENABLED=0 GOOS="${goos}" GOARCH="${goarch}" \

Conversation

mchenani commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkysel Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mchenani Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

mkysel Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

mkysel commented Feb 11, 2026

Uh oh!

mchenani commented Feb 11, 2026

Uh oh!

macroscopeapp bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes since #1622 opened

Uh oh!

Uh oh!

macroscopeapp bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mkysel Feb 11, 2026 •

edited

Loading

macroscopeapp bot commented Feb 12, 2026 •

edited

Loading