refactor(kb): unify exception handling in KB API and RAG pipelines#122
Open
sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
Open
refactor(kb): unify exception handling in KB API and RAG pipelines#122sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
Conversation
- Add _handle_ingestion_error() in document_ingestion to centralize error handling and remove duplicated RagCoreException/Exception branches - Add _handle_search_error() in document_search to unify search pipeline error handling - Add handle_kb_exceptions decorator in kb.py for KB API routes; map ValueError/KeyError/TypeError -> 400, PermissionError/OSError -> 403, other Exception -> 500 - Apply decorator to ingest, list_collections_api, search, ingest_web, delete_collection_api, delete_document_api, rename_collection_api, get_parse_result_api; remove redundant try/except in each handler - Keep list_collections_api asyncio.TimeoutError -> 503 and get_parse_result_api DocumentNotFoundError -> 404 Migrated from FenixAOS feat/rag_exception_unification. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.