fix(version-management): main pointer NULL model_tag and merge_insert#124
Open
sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
Open
fix(version-management): main pointer NULL model_tag and merge_insert#124sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
sqhyz55 wants to merge 1 commit intoxorbitsai:mainfrom
Conversation
Collaborator
sqhyz55
commented
Mar 10, 2026
sqhyz55
commented
- Add _normalize_model_tag() to treat None as '' for backward compatibility
- get_main_pointer: use escape_lancedb_string for filters; support both '' and NULL for model_tag; prefer non-NULL when multiple rows exist
- set_main_pointer: use merge_insert instead of delete-then-add to avoid race conditions; preserve created_at; migrate NULL model_tag to '' on write before merge_insert
- list_main_pointers: return model_tag as '' when NULL
- delete_main_pointer: use normalized_tag and escape_lancedb_string for filter expression
- Sync test_main_pointer_manager with new behavior and patch targets.
- Add _normalize_model_tag() to treat None as '' for backward compatibility - get_main_pointer: use escape_lancedb_string for filters; support both '' and NULL for model_tag; prefer non-NULL when multiple rows exist - set_main_pointer: use merge_insert instead of delete-then-add to avoid race conditions; preserve created_at; migrate NULL model_tag to '' on write before merge_insert - list_main_pointers: return model_tag as '' when NULL - delete_main_pointer: use normalized_tag and escape_lancedb_string for filter expression - Sync test_main_pointer_manager with new behavior and patch targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.