feat(rag): fix/embeddings-table-lazy-creation and unify schema migration#129
Open
sqhyz55 wants to merge 2 commits intoxorbitsai:mainfrom
Open
feat(rag): fix/embeddings-table-lazy-creation and unify schema migration#129sqhyz55 wants to merge 2 commits intoxorbitsai:mainfrom
sqhyz55 wants to merge 2 commits intoxorbitsai:mainfrom
Conversation
Collaborator
sqhyz55
commented
Mar 10, 2026
sqhyz55
commented
- schema_manager: add ensure_table_fields, refactor all 7 ensure* to use it (dict-style add_columns)
- schema_manager: add user_id to main_pointers table and migration
- vector_manager: improve read_chunks_for_embedding error handling and open_table checks
- search_engine: raise VectorValidationError when open_table fails
- document_ingestion: detailed embedding logs, v4 auto-detect, rate limit backoff
- document_search pipeline: per-stage timing logs
- document_search tool: fallback_to_sparse, warnings for no results / no embedding
- kb API: return 500 on ingest error, warn on partial; same for ingest_web
- frontend: handle IngestionResult error/partial and embedding_count=0
- tests: update vector_manager and main_pointer_manager mocks for user_id schema
…ify schema migration - schema_manager: add _ensure_table_fields, refactor all 7 ensure_* to use it (dict-style add_columns) - schema_manager: add user_id to main_pointers table and migration - vector_manager: improve read_chunks_for_embedding error handling and open_table checks - search_engine: raise VectorValidationError when open_table fails - document_ingestion: detailed embedding logs, v4 auto-detect, rate limit backoff - document_search pipeline: per-stage timing logs - document_search tool: fallback_to_sparse, warnings for no results / no embedding - kb API: return 500 on ingest error, warn on partial; same for ingest_web - frontend: handle IngestionResult error/partial and embedding_count=0 - tests: update vector_manager and main_pointer_manager mocks for user_id schema Made-with: Cursor
Update cascade cleaner and register_document tests to include required schema fields and mock open_table call sequence under lazy table creation. Made-with: Cursor
sqhyz55
force-pushed
the
fix/embeddings-table-lazy-creation
branch
from
53307bb to
ced52eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.