Skip to content

feat: add skill file access tools#142

Open
tanbro wants to merge 2 commits intoxorbitsai:mainfrom
tanbro:feat/add-skill-file-access-tools
Open

feat: add skill file access tools#142
tanbro wants to merge 2 commits intoxorbitsai:mainfrom
tanbro:feat/add-skill-file-access-tools

Conversation

@tanbro
Copy link
Contributor

@tanbro tanbro commented Mar 13, 2026

Summary

Add two tools for agents to access skill files:

  • read_skill_file(skill_name, file_path) - read files from skill directories
  • list_skill_files(skill_name, ...) - list files in skill directories

Changes

  • Add ToolCategory.SKILL enum
  • Add SkillTool class with proper category
  • Support multi-directory skill search (builtin -> user -> external)
  • Path traversal protection with input validation
  • Frontend i18n updates

Tests

21 tests covering all scenarios including security tests

tanbro added 2 commits March 13, 2026 13:54
- Add read_skill_file tool to access skill reference/resource files
- Add list_skill_files tool to discover skill files
- Add ToolCategory.SKILL enum for proper categorization
- Add SkillTool class for consistent tool typing
- Support multi-directory skill search (builtin, user, external)
- Add path traversal attack prevention
- Add comprehensive test coverage (21 tests)
- Update frontend i18n with skill tool category

This implements a controlled mechanism for agents to access skill
documentation while maintaining sandbox security boundaries.
Update test_instance_bound_tools.py to expect 17 tools instead of 15,
accounting for the 2 new skill file access tools.
@tanbro tanbro changed the title Feat/add skill file access tools add skill file access tools Mar 13, 2026
@qinxuye qinxuye changed the title add skill file access tools feat: add skill file access tools Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants