Merged
Conversation
…ction needed. Could mock yet more methods and possible return values, but there is already a facility for stubbing instead using TrustedPlatform. Also fix quoting and elaborate on test values.
Owner
|
Thanks for Your code but query will not work without extra '' around sequence name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I saw you do this PR zendframework#162 and had some trouble with unit tests. I just ran into this problem 2 days ago while working on PgSQL DDL decorators so thought would save you the headache and fill out quickly what I discovered the tests are looking for.
Sorry if the assistance was uncalled for. In case you do not like it, PR-ing it to you first, instead of directly to ZF repo. If you do, should be able to merge into your repo, and push to upstream again.