Fix String.slice for Elixir 1.16+ compatibility#166
Open
andreagrossetti wants to merge 1 commit intoxou:masterfrom
Open
Fix String.slice for Elixir 1.16+ compatibility#166andreagrossetti wants to merge 1 commit intoxou:masterfrom
andreagrossetti wants to merge 1 commit intoxou:masterfrom
Conversation
andreagrossetti
force-pushed
the
fix/string-slice-elixir-1.16
branch
from
ee9e218 to
813d8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Elixir 1.16+ shows deprecation warnings when using String.slice/2 with negative indices, affecting the color parsing functionality in lib/elixlsx/color.ex.
Solution: Updated String.slice/2 usage to use the modern 3-argument form with explicit length parameter
Updated development dependencies to ensure compatibility with current Elixir versions
No breaking changes to public API
Changes:
lib/elixlsx/color.ex: Fixed String.slice deprecation warning
mix.exs & mix.lock: Updated dev dependencies
This ensures elixlsx works cleanly with Elixir 1.16+ while maintaining full backward compatibility.