Conversation
This adds support for embedding images in workbooks. It technically does two main things: - Implements the changes introduced by [proactively's image support branch](https://github.com/proactively/elixlsx/tree/image-support-no-reformat) on top of the most recent commit to master - Adds `width` and `height` options to `Elixlsx.Image` so that it's possible to configure how many columns/rows and image should occupy
xou
left a comment
xou
left a comment
There was a problem hiding this comment.
Awesome, thank you so much! Just a few nitpicks :)
Thanks!
| <a:off x="1812547" y="3503925"/> | ||
| <a:ext cx="240431" cy="237600"/> |
There was a problem hiding this comment.
These numbers seem oddly specific. Can you add a comment where they come from?
|
|
||
| sheet7 = | ||
| sheet7 | ||
| |> Sheet.insert_image(0, 5, "ladybug-3475779_640.jpg") |
There was a problem hiding this comment.
Can you verify that this is a picture we can actually use in an open source project?
If required, can you add an attribution notice (not a legal expert, but maybe just a ladybug-3475779_640.jpg.NOTICE txt file or something)
|
|
||
| cond do | ||
| length(sheet.rows) <= rowidx -> | ||
| # append new rows, call self again with new sheet |
There was a problem hiding this comment.
The below code is now mostly handled by maybe_extend / dead, if I'm not mistaken?
|
Thank you so much for picking this up. The photo is a Free for commercial use |
|
@proactively My pleasure. My company needed this functionality ASAP for a client app, so it was great to find that most of the work had been done! I'll try and take a look at this and get it shaped up in the near future. |
|
@ngscheurich @xou Any news on this PR? Would be an awesome feature. |
|
For what it's worth, I'd love to have a release with this feature :-) |
|
Do you have any updates on this PR? |
|
Closing this in favor of #124. Thanks for your work, @ustrajunior! |
6 participants
This adds support for embedding images in workbooks. It technically does
two main things:
branch on top of the most recent commit to master
widthandheightoptions toElixlsx.Imageso that it'spossible to configure how many columns/rows an image should occupy
All the credit for this goes to proactively.
Note: This PR duplicates most of the work in #79. I needed a working copy of this ASAP for a project, so I created this branch. Feel free to close this in favor of #79 if work is still being done there!