fix(ci): correct publish.owner and skip publish in matrix builds#2
Open
charlieleith wants to merge 2 commits intoxp-technologies-dev:mainfrom
Open
fix(ci): correct publish.owner and skip publish in matrix builds#2charlieleith wants to merge 2 commits intoxp-technologies-dev:mainfrom
charlieleith wants to merge 2 commits intoxp-technologies-dev:mainfrom
Conversation
The publish config in package.json pointed at "p-stream/p-stream-desktop" which doesn't exist, so when electron-builder ran in the matrix build steps it auto-attempted to publish (because GH_TOKEN is set in env), queried the releases API for that nonexistent repo, got a 404, and failed every shard. Two fixes: - package.json: publish.owner -> "xp-technologies-dev" so the URL resolves to the real repo. - build-and-release.yml: pass --publish=never to all matrix build:* commands. The release job already uploads via `gh release upload`, so electron-builder never needs to talk to the releases API in the matrix shards. Either fix alone would unbreak the workflow; both together are defensive — if someone changes the repo location later, the matrix won't silently start hitting the API again.
Same root cause as the CI fix in the previous commit, but in runtime code: src/main/auto-updater.js, src/main/main.js (autoUpdater.setFeedURL call), and the "open releases page" shell.openExternal calls all hardcoded the wrong owner "p-stream". Result: every running app instance hits api.github.com/repos/p-stream/p-stream-desktop/releases/latest and gets HTTP 404 on every update check. Changes "p-stream" -> "xp-technologies-dev" in the three places it appears in src/main/.
Author
|
Pushed an additional commit (5754fdd) extending the same fix to runtime code:
Without these, even after a release exists at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Build and Releaseworkflow has been failing on every matrix shard. Root cause is inpackage.json:The repo actually lives at
xp-technologies-dev/p-stream-desktop. BecauseGH_TOKENis set in the matrix step env and apublishblock exists inpackage.json, electron-builder auto-attempts to publish during eachbuild:*invocation. That triggersGET https://api.github.com/repos/p-stream/p-stream-desktop/releases, which 404s, which fails the build before any artifact is uploaded. Every Linux/Windows/macOS shard dies the same way; thereleasejob is then skipped becauseneeds:is unsatisfied.Failure log excerpt (from run 23325331797, build-linux x64):
Fix
Two small changes — either alone unbreaks CI, both together are defensive:
package.json:publish.owner→xp-technologies-devso the URL resolves to the real repo..github/workflows/build-and-release.yml: pass--publish=neverto every matrixbuild:*command. The release job already uploads viagh release upload, so electron-builder never needs to touch the releases API in the matrix shards. (This matches what the existingdistscript does.)Test plan
Build and Releaseviaworkflow_dispatchafter merge — all six matrix jobs (linux/win/mac × x64/arm64) should reach the artifact upload step.pnpm run build:linux --publish=neverproducesdist/P-Stream-1.2.6.AppImage(111 MB) without hitting the releases API.Notes / not in scope
actions/checkout@v4andactions/setup-node@v4will be deprecated June 2, 2026 (Node 20 EOL on runners). Worth a follow-up bump, but out of scope here.