REF: update method in plotting #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ-Wright
reviewed
Dec 6, 2018
xpdview/waterfall.py
Outdated
| "#AB987A", "#C09F80", "#b0b0b0ff"] | ||
| mpl.rcParams['axes.prop_cycle'] = cycler(color=simonCycle2) | ||
| from pkg_resources import resource_filename as rs_fn | ||
| style_fp = rs_fn('xpdview', 'billinge.mplstyle') |
Member
There was a problem hiding this comment.
Can we pull this from a url (just in case we change things?)
Member
There was a problem hiding this comment.
Is it possible for this to be handled externally from the waterfall module? Could users do this themselves at the beamline, in case they want their own configuration?
| self.x_offset_slider = Slider(x_offset_slider_ax, | ||
| 'x-offset', 0.0, 1.0, | ||
| valinit=0.1, valfmt='%1.2f') | ||
| valinit=0., valfmt='%1.2f') |
xpdview/waterfall.py
Outdated
| self.ax.plot(x, y, label=k, picker=5, | ||
| **self.kwargs) | ||
| # update matplotlib line data | ||
| lines = self.ax.get_lines() |
New data can be added properly through update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating new mpl line instances every time which becomes expensive when hundreds of curves are fed, we cache them and redraw with the new data value to speed things up.
This PR is not finished yet.