collector: Allocate space on heap for chunks#74
Open
bkylerussell wants to merge 1 commit intoxrmx:masterfrom
Open
collector: Allocate space on heap for chunks#74bkylerussell wants to merge 1 commit intoxrmx:masterfrom
bkylerussell wants to merge 1 commit intoxrmx:masterfrom
Conversation
Nicer for embedded devices which may have smaller stack limitations.
Owner
|
Thanks for the patch, have you hit this in practice? If so on which hardware? |
Author
|
Yes, I hit this trying to run bootchart on a board where we limit stack size to 128K, which CHUNK_SIZE meets. I was running on an ARM platform. |
troglobit
added a commit
to finit-project/InitViz
that referenced
this pull request
Jan 1, 2026
Move 128KB buffer allocation from stack to heap to avoid stack overflow on embedded devices with limited stack size (e.g., 128KB). Also address other heap usage and bad coding habits. Based on: xrmx/bootchart#74 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nicer for embedded devices which may have smaller stack limitations.