This repository was archived by the owner on Dec 26, 2025. It is now read-only.
Fix: Handle cancel action in rename notebook (Fixes #186)#365
Open
jainhj13 wants to merge 1 commit intoxy2z:masterfrom
Open
Fix: Handle cancel action in rename notebook (Fixes #186)#365jainhj13 wants to merge 1 commit intoxy2z:masterfrom
jainhj13 wants to merge 1 commit intoxy2z:masterfrom
Conversation
Owner
|
Thanks for the contribution, however this project hasn't been active for years and should probably just be archived... sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the JavaScript crash reported in #186 when cancelling the rename notebook action.
Changes Made:
Crash Fix: Added a guard clause if (new_title === null) to handle the Cancel action gracefully.
Validation: Users are now alerted if they try to save an empty notebook title.
Refactor: Improved the rename logic to use optimistic UI updates for a snappier user experience.
Testing: Verified that clicking "Cancel" no longer freezes the application and that empty titles trigger the appropriate alert.