-
-
Notifications
You must be signed in to change notification settings - Fork 154
fix: broken alembic import with alembic 1.15. Solves issue #368 #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@xzkostyan Could you take a look at this PR? It will be really helpful to merge this. |
|
@xzkostyan is there any chance this PR could be reviewed and released. The PR looks good, as the changes are the same that were done in the original alembic's PR. |
|
@PabloReszczynski thx for the approval. What about merging this PR (I don't know the process in this repo)? Is there anything I need to do? |
|
@xzkostyan , @thomas-dufour , hello. Could you point out where are the results of the CI for this PR? I am aware about this page, but are the jobs are shown here and they are just unavailable for me or they are not? Also, this PR is necessary for the #379 , it solves the import problems in general. @xzkostyan , who are project maintainers? Could you name them, please? |
| elif alembic_version >= (1, 11, 0): | ||
| return sqla_compat._reflect_table(inspector, table) | ||
| else: | ||
| return _alembic_reflect_table(inspector, table, None) | ||
| return sqla_compat._reflect_table(inspector, table, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| elif alembic_version >= (1, 11, 0): | |
| return sqla_compat._reflect_table(inspector, table) | |
| else: | |
| return _alembic_reflect_table(inspector, table, None) | |
| return sqla_compat._reflect_table(inspector, table, None) | |
| if alembic_version >= (1, 11, 0): | |
| return sqla_compat._reflect_table(inspector, table) | |
| return sqla_compat._reflect_table(inspector, table, None) |
Just if is enough in lieu of an elif and then else clause because of immediate return statements.
Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.