Use individual lodash methods#113
Open
realityking wants to merge 5 commits intoxzyfer:masterfrom
Open
Conversation
realityking
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to how
node-sassworks, this changes the way lodash functions are loaded to only require the specific methods that are actually used bysass-graph.I also went through all the used lodash functions and replaced any with native ES5 functionality where that's available. Once
sass-graphrequires a higher Node.js version more could be eliminated.With this PR only 3 lodash functions are used:
includes(native replacement available with Node.js 6.4)intersectionuniq