-
Notifications
You must be signed in to change notification settings - Fork 0
Remove need to loop speaker #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jgoeders, I would like to get your thoughts on the code. I think the changes I made here should work just fine in the y-board-v3 library because all the changes are done in the yboard.cpp file and not yaudio.cpp. |
|
Specifically, I want your thoughts on creating and then deleting the task if all the notes are done. My other thought was to create the task in the setup function and just let it sit there if there is nothing to play. But I liked the idea of not having the task running unless someone is using the speaker. 🤷 |
|
Looks pretty clean. If it works reliably, I think this is a good way to do it. |
|
Before we merge this, I would like to make sure removing |
|
@philipbl This looks great. Thanks for doing all this! |
I removed the loop_speaker function and instead create a task that calls loop on the users behalf when playing notes in the background.