Skip to content

Clearing a field entirely #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oarod wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

Clearing a field entirely #1351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bed4605
Clear field entirely with backspace/delete
oarod Jul 19, 2017
92060b1
Add link to pull request
oarod Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@
// Firefox thrown an error when calling `formatBlock` on an empty editable blockContainer that's not a <div>
if (MediumEditor.util.isMediumEditorElement(node) && node.children.length === 0 && !MediumEditor.util.isBlockContainer(node)) {
this.options.ownerDocument.execCommand('formatBlock', false, 'p');

// https://github.com/yabwe/medium-editor/issues/1350
// https://github.com/yabwe/medium-editor/pull/1351
// Pressing backspace/delete once more on an already empty field will clear it entirely
if (MediumEditor.util.isKey(event, [MediumEditor.util.keyCode.DELETE, MediumEditor.util.keyCode.BACKSPACE])) {
this.setContent(null);
}
}

// https://github.com/yabwe/medium-editor/issues/834
Expand Down