Skip to content

Conversation

@zakkas783
Copy link

No description provided.

@saki7
Copy link
Collaborator

saki7 commented Aug 8, 2025

Thanks for the contribution, all the changes seem reasonable to me.

Regarding your reply on Twitter, I'm not sure if you have any plan to proceed on "deeper" review. I'll keep this open for a while, so feel free to push additional changes (if you have any). When the review is complete, please notify us so that we can merge this.

BTW: Our CI is failing for some technical issues. We will fix this on our part.

@saki7 saki7 added the documentation Improvements or additions to documentation label Aug 8, 2025
@saki7
Copy link
Collaborator

saki7 commented Aug 9, 2025

I rebased your branch on HEAD and force-pushed into your fork. We have updated our configuration to allow workflow runs from outside contributors, so I think the error is fixed now.

Please run git fetch origin && git reset --hard origin/pr/fix on your local machine. (Make sure to backup your local work before doing rebase.)

@saki7
Copy link
Collaborator

saki7 commented Aug 21, 2025

Note that the semantics on recursive_wrapper has changed in #45. Sorry for the inconvenience, but the change is minimal, and actually simplifies the semantics, so tracking the change should be easy. No other parts are affected, as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants