Trigger assertions to detect UB on self-emplace and self-generic-assignment #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-emplace and self-generic-assignment on non-valueless instance ALWAYS leads to UB, because the standard specifies
emplaceto destruct the contained object before emplacing the new value:This does apply also to generic assignment operator as the standard says it delegates to
emplaceon certain branches:Our version (
rvariantversion) of the specification ([rvariant.mod]) allows creating temporary variable onrecursive_wrapper, making it bulletproof to self-emplace. However, there's no point of conditionally omitting the assertion on that branch, because doing so would only make the codebase error-prone and has no benefit for end users.Also fixes the wrong semantics where our implementation of generic assignment operator was not conforming to the standard, creating temporary object in non-permitted branch.