Skip to content

Conversation

@saki7
Copy link
Collaborator

@saki7 saki7 commented May 22, 2025

// previous implementation
BOOST_TEST(((PartialPartial{NaN, 1.0} <=> PartialPartial{NaN, 2.0}) == std::partial_ordering::unordered));
BOOST_TEST((comp(PartialPartial{NaN, 1.0}, PartialPartial{NaN, 2.0}) == std::partial_ordering::unordered));

// after this PR
BOOST_TEST(((PartialPartial{NaN, 1.0} <=> PartialPartial{NaN, 2.0}) == std::partial_ordering::unordered));
BOOST_TEST((comp(PartialPartial{NaN, 1.0}, PartialPartial{NaN, 2.0}) == std::partial_ordering::less));

@yaito3014 Can you confirm this is correct? If so please merge thanks!

@saki7 saki7 added this to the yk_util v0.4 milestone May 22, 2025
@saki7 saki7 added the bug Something isn't working label May 22, 2025
@cppwarningnotifier
Copy link

Environment C++23 C++26
ubuntu24.04Clang19Debug✅success✅success
Release✅success✅success
20Debug✅success✅success
Release✅success✅success
GCC14Debug✅success✅success
Release✅success✅success
windows2022MSVCv142Debug✅success✅success
Release✅success✅success

Copy link
Owner

@yaito3014 yaito3014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaito3014 yaito3014 merged commit 4e05ca2 into main May 22, 2025
18 checks passed
@yaito3014 yaito3014 deleted the compare-fix branch May 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants