feat(rating): backport from angular-ui/bootstrap, now using ngModel#255
Open
kralo wants to merge 3 commits intoyalabot:masterfrom
Open
feat(rating): backport from angular-ui/bootstrap, now using ngModel#255kralo wants to merge 3 commits intoyalabot:masterfrom
ngModel#255kralo wants to merge 3 commits intoyalabot:masterfrom
Conversation
Member
|
Thanks for sending this in @kralo. Integrating with |
Author
|
@jbrowning updated the gruntfile, please have a look again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possibly adressing #238
foundation update due to .show-for-sr (foundation/foundation-sites@7bb9efc)
BREAKING CHANGE:
ratingis now integrated withngModelController.valueis replaced fromng-model.Before:
<rating value="rate" ...></rating>After:
<rating ng-model="rate" ...></rating>