Add --no-evict-root-childs flag#136
Open
VikNorway wants to merge 1 commit intoyandex-cloud:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
--no-evict-root-childsflag. It prevents eviction of child directories of the root inode and updates theirExpiredTime. It seems to work fine, but there is a small bug: when--entry-limitis small (less than the number of child directories), MetaEvictor starts an infinite loop of eviction attempts. When--entry-limitis large, everything works fine.If one bucket is mounted and child folders are mounted as a volume in docker, geesefs crashed with the error "Bad file descriptor" after MetaEvictor run. After I excluded evicting child folders, the error no longer appears.
But I'm sure that the error will repeat if you mount a child folder of a child folder in docker. That is, for example,
/mnt/datais the mount point of the bucket. Then mounting /mnt/data/dir1 in docker will not cause an error, but/mnt/data/dir1/subdir1will.