Develop1 #1144
Open
Develop1 #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulianaGusakova
commented
Oct 7, 2025
YulianaGusakova
commented
- собран Maven-проект в IntelliJ IDEA с использованием Java 11 и подключением библиотек JUnit 4, Jacoco, Mockito;
- покрыт юнит-тестами класс Burger;
- применены параметризация и моки;
- сгенерирован отчет с помощью Jacoco для оценки покрытия кода тестами.
okryukova
reviewed
Oct 15, 2025
| burger.addIngredient(mockIngredientSauce); | ||
| burger.addIngredient(mockIngredientBun); | ||
| burger.addIngredient(mockIngredientFilling); | ||
| assertEquals("После добавления трёх ингредиентов размер списка должен быть равен 3", 3, burger.ingredients.size()); |
There was a problem hiding this comment.
⛔️Нужно исправить. Для юнит-тестов придерживаемся подхода: один тест, значит одна проверка. Если очень хочется несколько проверок -- тогда используем softAssertions. Поправь, пожалуйста, во всем коде
| assertEquals("Некорректное перемещение ингредиента между позициями", mockIngredientBun, burger.ingredients.get(1)); | ||
| } | ||
|
|
||
| @Parameterized.Parameters(name = "Цена булочки {0}, Ожидаемая итоговая цена {1}, Количество ингредиентов {2}") |
There was a problem hiding this comment.
⛔️Нужно исправить. Если в тестах не нужна параметризация, например, тест moveIngredientTest, то их нужно вынести в отдельный класс
…terizedTest, исправлен код в BurgerTest, изменен pom.xml
okryukova
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.