Conversation
AlexKitIt
reviewed
May 6, 2025
tests.py
Outdated
Comment on lines
8
to
10
| @pytest.fixture | ||
| def collector(self): | ||
| return BooksCollector() |
Collaborator
There was a problem hiding this comment.
Нужно исправить: фикстуры живут в conftest
AlexKitIt
reviewed
May 6, 2025
tests.py
Outdated
Comment on lines
21
to
26
| def test_add_new_book_incorrect_add_book_unsuccessful_add(self, collector): | ||
| collector.add_new_book('Азбука') | ||
| assert len(collector.get_books_genre()) == 1 | ||
| collector.add_new_book('Азбука') | ||
| assert len(collector.get_books_genre()) == 1 | ||
| collector.add_new_book('Азбука' * 10) |
Collaborator
There was a problem hiding this comment.
Нужно исправить: в юнит тесте assert один и это должен быть параметризованный тест
AlexKitIt
reviewed
May 6, 2025
tests.py
Outdated
Comment on lines
34
to
39
| def test_set_book_genre_incorrect_genre_unsuccess(self, collector): | ||
| collector.set_book_genre('Азбука', 'Ужасы') | ||
| assert len(collector.books_genre) == 0 | ||
| collector.add_new_book('Азбука') | ||
| collector.set_book_genre('Азбука', 'FFFFFF') | ||
| assert collector.books_genre['Азбука'] == '' |
Collaborator
There was a problem hiding this comment.
здесь и далее: comment up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.