Do not delete zero-copy locks by default

[kirillgarbar]

Summary by Sourcery

Make zero-copy lock deletion opt-in by adding a flag and conditionally running the cleanup only when requested

Enhancements:

• Add --delete-zero-copy-locks option to clickhouse-hosts command
• Add --delete-zero-copy-locks option to remove-hosts-from-table command
• Guard delete_zero_copy_locks calls behind the new flag so locks aren’t removed by default

[sourcery-ai]

Reviewer's Guide

This PR refactors two Zookeeper-related CLI commands to make zero-copy lock deletion opt-in by adding a new flag and guarding the existing deletion logic with it.

Sequence diagram for guarded zero-copy lock deletion in clickhouse_hosts_command

sequenceDiagram
    actor User
    participant CLI
    participant "delete_zero_copy_locks()"
    User->>CLI: Run clickhouse_hosts_command with/without --delete-zero-copy-locks
    CLI->>CLI: Check if delete_locks flag is set
    alt delete_locks is True
        CLI->>"delete_zero_copy_locks()": Delete locks for each host
    else delete_locks is False
        CLI->>CLI: Skip zero-copy lock deletion
    end

Loading

Sequence diagram for guarded zero-copy lock deletion in remove_hosts_from_table

sequenceDiagram
    actor User
    participant CLI
    participant "delete_zero_copy_locks()"
    User->>CLI: Run remove_hosts_from_table with/without --delete-zero-copy-locks
    CLI->>CLI: Check if delete_locks flag is set
    alt delete_locks is True
        CLI->>"delete_zero_copy_locks()": Delete locks for each host
    else delete_locks is False
        CLI->>CLI: Skip zero-copy lock deletion
    end

Loading

File-Level Changes

Change	Details	Files
Introduce an optional --delete-zero-copy-locks flag	Add @option decorator for --delete-zero-copy-locks to both clickhouse_hosts_command and remove_hosts_from_table Extend both function signatures with a delete_locks boolean parameter	ch_tools/chadmin/cli/zookeeper_group.py
Make zero-copy lock deletion conditional on the new flag	Wrap delete_zero_copy_locks calls inside if delete_locks: blocks in both commands	ch_tools/chadmin/cli/zookeeper_group.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}