Fix prepared statement cache invalidation on DEALLOCATE#1235
Open
evkuzin wants to merge 12 commits intoyandex:masterfrom
Open
Fix prepared statement cache invalidation on DEALLOCATE#1235evkuzin wants to merge 12 commits intoyandex:masterfrom
evkuzin wants to merge 12 commits intoyandex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pool_reserve_prepared_statement is enabled, Odyssey tracks which prepared statements have been deployed to each backend connection. However, when a client sends DEALLOCATE ALL, PostgreSQL removes all prepared statements but Odyssey's cache (server->prep_stmts) was not being cleared.
This caused "prepared statement does not exist" errors when:
Client prepares and executes a statement
Client sends DEALLOCATE ALL (e.g., psycopg after ROLLBACK)
Client reuses the same query - Odyssey skips Parse (thinks statement exists), sends only Bind
PostgreSQL returns error since the statement was deallocated
Fix: Detect DEALLOCATE queries and invalidate server->prep_stmts, matching the existing behavior for DISCARD. Handles both simple query protocol and extended query protocol (Parse/Bind).
You can use this script to replicate a bug: