Conversation
egnees
changed the title
sakateka
reviewed
Nov 28, 2025
Collaborator
sakateka
left a comment
sakateka
left a comment
There was a problem hiding this comment.
It appears the trie cannot be used across processes via shared memory, although this might be acceptable. Additionally, collect_rule_classifiers_rec uses a stack without bounds checking, which is potentially problematic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes minor bugs in filter and brings benchmark versus DPDK ACL module.
Also, as experiment the trie data structure was implemented, which allows to make packet classification on IPv4 address. Trie appears to be less effective on the lookup query, than LPM. So, the LPM is still used and trie is being study for now.