Conversation
introduce transport protocol enum move tunnel kind into VS config
3Hren
reviewed
Apr 29, 2026
Member
There was a problem hiding this comment.
This pollutes a project-wide header with the two most overloaded short names in the codebase.
3Hren
reviewed
Apr 29, 2026
| struct memory_context *mctx = &agent->memory_context; | ||
| free_vs_matchers(cfg); | ||
| free_vs_array(mctx, ADDR_OF(&cfg->vs), cfg->vs_count, workers); | ||
| cp_module_fini(&cfg->cp_module); |
Member
There was a problem hiding this comment.
rcu_free (to mirror rcu_init in the init_module_config)?
btw, why there is free_module_config before init_module_config and not the opposite?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.