Skip to content

fix: add FLAIR2_ prefix to all ECS environment variable names #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0b00101111 merged 1 commit into from
Mar 28, 2026
Merged

fix: add FLAIR2_ prefix to all ECS environment variable names #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions terraform/modules/ecs/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ resource "aws_ecs_task_definition" "api" {
}]

environment = [
{ name = "REDIS_URL", value = var.redis_url },
{ name = "S3_BUCKET", value = var.s3_bucket_name },
{ name = "ENV", value = var.env }
{ name = "FLAIR2_REDIS_URL", value = var.redis_url },
{ name = "FLAIR2_S3_BUCKET", value = var.s3_bucket_name },
{ name = "FLAIR2_ENVIRONMENT", value = var.env }
]
Comment on lines 56 to 60
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says these are consumed via settings.redis_url / settings.s3_bucket, but the current backend Settings model (backend/app/config.py) does not define redis_url or s3_bucket, and a repo-wide search shows no other usage. Either add those settings fields in the backend (so these env vars actually take effect) or update the PR description / remove these env vars to avoid misleading configuration drift.

Copilot uses AI. Check for mistakes.

secrets = [
Expand Down Expand Up @@ -144,9 +144,9 @@ resource "aws_ecs_task_definition" "worker" {
]

environment = [
{ name = "REDIS_URL", value = var.redis_url },
{ name = "S3_BUCKET", value = var.s3_bucket_name },
{ name = "ENV", value = var.env }
{ name = "FLAIR2_REDIS_URL", value = var.redis_url },
{ name = "FLAIR2_S3_BUCKET", value = var.s3_bucket_name },
{ name = "FLAIR2_ENVIRONMENT", value = var.env }
]
Comment on lines 146 to 150
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as API task definition: the repo’s backend config currently has no Settings.redis_url / Settings.s3_bucket fields and there are no code references to these values. If the worker is expected to consume them, add the settings fields (or otherwise ensure the application reads FLAIR2_REDIS_URL / FLAIR2_S3_BUCKET) or update the PR description to match current behavior.

Copilot uses AI. Check for mistakes.

secrets = [
Expand Down
Loading