Skip to content

feat: pass bodyElement to move the ModalDialog inside a specific element #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyril-sf wants to merge 1 commit into from
Closed

feat: pass bodyElement to move the ModalDialog inside a specific element #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addon/components/modal-dialog/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
@clickOutsideToClose={{@clickOutsideToClose}}
@destinationElementId={{this.destinationElementId}}
@overlayPosition={{this.overlayPosition}}
@bodyElement={{@bodyElement}}
@tetherTarget={{@tetherTarget}}
@legacyTarget={{@target}}
@attachment={{@attachment}}
Expand Down
1 change: 1 addition & 0 deletions addon/components/tether-dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default class TetherDialog extends BasicDialog {

targetAttachment = null;
attachment = null;
bodyElement = null;

didReceiveAttrs() {
super.didReceiveAttrs(...arguments);
Expand Down
1 change: 1 addition & 0 deletions addon/templates/components/tether-dialog.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
{{/if}}
<EmberTether
class={{this.containerClassNamesString}}
@bodyElement={{this.bodyElement}}
@target={{this.tetherTarget}}
@attachment={{this.attachment}}
@targetAttachment={{this.targetAttachment}}
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"ember-source": "~3.28.8",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^3.16.0",
"ember-tether": "^3.0.0",
"ember-tether": "git+ssh://git@github.com/yapplabs/ember-tether.git#feat/body-element",
"ember-truth-helpers": "^3.0.0",
"ember-try": "^2.0.0",
"eslint": "^7.32.0",
Expand All @@ -87,7 +87,7 @@
},
"peerDependencies": {
"@ember/string": "^3.0.0 || ^4.0.0",
"ember-tether": "^3.0.0",
"ember-tether": "git+ssh://git@github.com/yapplabs/ember-tether.git#feat/body-element",
"liquid-tether": "^2.0.7",
"liquid-wormhole": "^3.0.1"
},
Expand Down
25 changes: 13 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading