Open
Conversation
Owner
|
There's a simpler way to do this. All you'd need is a wrapper script like send_job that takes a shell script as input and submits it to the cluster, passing it whatever parameters are needed. Then you just register send_job as the cluster submission script in the MISO settings file. It doesn't make sense for us to support every cluster system and its quirks, especially since if I incorporate this code, I'll have no way of testing it (I have no access to Slurm clusters.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the request of a colleague here, I've done a rearrangement of the cluster code to support Slurm.
I did a fairly substantial refactoring of the cluster code to make it easier to customize the support for a given system. Basically I took the cluster_utils functions (e.g. launch_job) and set them up on some factory managed "cluster engine" classes. The factory chooses the engine based on the cluster command entry in the settings file (e.g. "bsub" returns the LsfClusterEngine).
One of the reasons that I did this is that running Slurm jobs in our environment really didn't fit in well with the existing code. Given Slurm's requirement that memory be specified; our internal requirement for a time setting; the different possible partitions and module loads that we might need; I chose to set a jobscript template via miso_settings into which the command is substituted. This should provide maximum flexibility for submitting jobs without requiring all sbatch parameters be supported individually by the settings file.