feat: remove nav element from pagination / explicitly add navigation …#49
Closed
Yannicvanveen wants to merge 1 commit intomainfrom
Closed
feat: remove nav element from pagination / explicitly add navigation …#49Yannicvanveen wants to merge 1 commit intomainfrom
Yannicvanveen wants to merge 1 commit intomainfrom
Conversation
Yannicvanveen
requested review from
Rovasch,
SimonvanWijhe,
dtakken,
hnccox-yard,
ictbeheer,
mvdhoek1 and
rivanuff
YvetteNikolov
requested changes
Feb 6, 2026
Contributor
There was a problem hiding this comment.
Nope, role="navigation" op een ul is problematisch.
Dit kunnen we voor nu -helaas- het beste oplossen in de Brave Frontend Kit JavaScript. Op elke FacetWP reload moeten we de role="navigation" van de ul afhalen.
Éigenlijk moeten we onze eigen FacetWP A11y improvements gaan schrijven, want hun improvements zijn slecht én ontoereikend. Hierarchische checkboxes werken bijv. niet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FacetWP voegt zelf met jQuery al een navigation role toe aan .facetwp-pager, daardoor zijn er twee elementen met een navigation role. Ik heb de role hier ook expliciet toegevoegd.