Draft
Conversation
WybeBosch
requested review from
FreakyWizard,
JasperS20,
Rovasch,
SimonvanWijhe,
Yannicvanveen,
YvetteNikolov,
dtakken,
hnccox-yard,
ictbeheer,
laravdiemen,
mvdhoek1 and
rivanuff
and removed request for
a team
| @foreach ($item->children as $child) | ||
| <li class="menu-item"> | ||
| <a href="{{ $child->url }}" @class([ | ||
| 'group/child flex items-center px-6 py-3 text-left leading-snug text-inherit no-underline', |
Contributor
There was a problem hiding this comment.
Deze group/child mag weg?
Contributor
|
Je moet nog:
|
| {{ $item->label }} | ||
|
|
||
| @if ($item->children) | ||
| <i class="fa-light fa-chevron-down pl-2"></i> |
Contributor
There was a problem hiding this comment.
Hier kunnen we nu een SVG van maken! Net zoals in de search bar. Scheelt weer zo'n layout shift,
| <a href="{{ $item->url }}" @class([ | ||
| 'relative flex h-full items-center px-2 text-center text-sm leading-snug text-black no-underline xl:px-4 xl:text-base xl:leading-snug hocus:text-primary', | ||
| 'text-primary' => $item->active || $item->activeParent, | ||
| $item->classes, |
Contributor
There was a problem hiding this comment.
aria-current toevoegen als het active is. Check sowieso even of je nog andere aria attributen mist met acceptatie
WybeBosch
force-pushed
the
feat/add-navi-for-navigation-menu
branch
from
cc012b8 to
3da8f63
Compare
Composer package changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft
maar ACF is niet opensource / free volgens mij.