fix(build): Apply bundle fix to legacy build#6303
Merged
arcanis merged 1 commit intoyarnpkg:masterfrom Aug 28, 2018
Merged
Conversation
|
The Webpack config for the modern build was adjusted recently to add a loader, which is used as a workaround for a bug introduced by a recent dependency update. The legacy config needed the same update. The Webpack config was also updated in superficial ways to follow recommendations made for migrating from Webpack v1 to v2 (e.g. using `module.rules` instead of `module.loaders`). These changes should have no functional impact, and should make migrating to future versions of Webpack easier. fix yarnpkg#6269
Gudahtt
force-pushed
the
update-webpack-config
branch
from
893fb66 to
a78d3c1
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Webpack config for the modern build was adjusted recently to add a loader,
which is used as a workaround for a bug introduced by a recent dependency
update. The legacy config needed the same update.
The Webpack config was also updated in superficial ways to follow
recommendations made for migrating from Webpack v1 to v2 (e.g. using
module.rulesinstead ofmodule.loaders). These changes should have nofunctional impact, and should make migrating to future versions of Webpack
easier.
fix #6269
Test plan
I have tested building and running both the modern and legacy builds. Before this change, the artifact from the modern build worked, but the one from the legacy build did not. Now they both work.
I also compared the stdout from running the
build-bundlecommand, before and after this change (it prints the list of files included in the bundle). The output matched exactly.